Skip to content

Go plugin fixes #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2023
Merged

Go plugin fixes #1851

merged 2 commits into from
Feb 27, 2023

Conversation

egiptipavel
Copy link
Collaborator

Description

  • Enable plugin action in context menu for Go-files
  • Automatic detection of Go Project SDK

Fixes #1828
Fixes #1805

How to test

Manual tests

Self-check list

Check off the item if the statement is true. Hint: [x] is a marked item.

Please do not delete the list or its items.

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@egiptipavel
Delete project SDK field from UnitTestBot action dialog. Add auto det…
902fe24 
…ection of project SDK and error dialogs when SDK isn't setup or version less than 1.18
@egiptipavel
Run plugin action from context menu
9b794f0
@egiptipavel egiptipavel added ctg-enhancement New feature, improvement or change request ctg-bug-fix PR is fixing a bug lang-go Issue is related to Go support labels Feb 26, 2023
@egiptipavel egiptipavel self-assigned this Feb 26, 2023
@Markoutte Markoutte requested review from Vassiliy-Kudryashov and removed request for Markoutte February 27, 2023 06:53
@egiptipavel egiptipavel merged commit fadba72 into main Feb 27, 2023
@egiptipavel egiptipavel deleted the egiptipavel/define-go-project-sdk branch February 27, 2023 20:12
@alisevych alisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vassiliy-Kudryashov Vassiliy-Kudryashov Vassiliy-Kudryashov approved these changes

Assignees

@egiptipavel egiptipavel

Labels
ctg-bug-fix PR is fixing a bug ctg-enhancement New feature, improvement or change request lang-go Issue is related to Go support
Projects
None yet
Milestone
2023.3 Release
Development

Successfully merging this pull request may close these issues.

Plugin action is not available in context menu for GO-files Go Project SDK should be detected automatically
3 participants
@egiptipavel @Vassiliy-Kudryashov @alisevych